-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for sprite #390
Conversation
@birkskyum I was trying to make codespaces run the docs site but it didn't work well... |
@louwers did what I wrote make sense? Is it clear? Is the english OK? |
Can I push some changes? You can see if you like them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 78.02% 78.02%
=======================================
Files 101 101
Lines 4142 4142
Branches 1184 1184
=======================================
Hits 3232 3232
Misses 910 910 ☔ View full report in Codecov by Sentry. |
I restructered and reworded things a bit. Hope you like it. I think this sentence should be removed or reworded? Do you know what it is trying to say?
|
I can't see it in comparison to the current page, did you intentionally add a md file? |
Yes, it means you can use feature properies from a vector tile source to set the image icon, similar to the |
Oops... @HarelM Fixed now. |
Fixes #389 - Sprite Documentation is Outdated
Add other data to that page.
Update some versions support in the v8 file.